Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deepseek-coder-v2 in siliconflow #6149

Merged
merged 8 commits into from
Jul 29, 2024
Merged

add deepseek-coder-v2 in siliconflow #6149

merged 8 commits into from
Jul 29, 2024

Conversation

senseb
Copy link
Contributor

@senseb senseb commented Jul 10, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Close #6148

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 10, 2024
@crazywoola crazywoola requested a review from takatost July 10, 2024 11:05
@crazywoola
Copy link
Member

Please fix the lint errors in CI

@crazywoola
Copy link
Member

crazywoola commented Jul 12, 2024

https://github.com/deepseek-ai/DeepSeek-Coder-V2

It seems it has upgrade it's context length to 128k

Link #6215

@senseb

@senseb
Copy link
Contributor Author

senseb commented Jul 12, 2024

@takatost Could you help review the code?

@senseb
Copy link
Contributor Author

senseb commented Jul 12, 2024

128k

currently, siliconflow support 32K context length. see: https://siliconflow.cn/models#models

@crazywoola crazywoola requested a review from laipz8200 July 12, 2024 11:56
crazywoola
crazywoola previously approved these changes Jul 14, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 14, 2024
@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Jul 15, 2024
@senseb senseb requested a review from takatost July 17, 2024 01:51
@crazywoola
Copy link
Member

Hello please resolve that conversation, once it's resolved, we can merge it into main.

@senseb
Copy link
Contributor Author

senseb commented Jul 25, 2024

@takatost i have resolve the aforementioned conversation, please check again.

@senseb senseb requested a review from takatost July 25, 2024 05:30
Copy link
Collaborator

@takatost takatost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 29, 2024
@takatost takatost merged commit 3e18d32 into langgenius:main Jul 29, 2024
5 checks passed
@takatost takatost mentioned this pull request Aug 5, 2024
cuiks pushed a commit to cuiks/dify that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate SiliconFlow DeepSeek-V2-Coder Model and Update Naming Conventions in Dify
3 participants