Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README, deploy dify with YAML file on Kubernetes #5131

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Update README, deploy dify with YAML file on Kubernetes #5131

merged 3 commits into from
Jun 14, 2024

Conversation

Winson-030
Copy link
Contributor

Description

Add repository dify-kubernetes which can deploy with YAML file on Kubernetes

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Successfully deployed on local Kubernetes cluster

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@Winson-030
Update README.md
78116ca 
add repository dify-kubernetes which can deploy with YAML file on Kubernetes
@Winson-030
Update README_CN.md
d79ce61 
增加 dify-kubernetes ，使用 YAML 文件部署到 Kubernetes
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 📚 documentation Improvements or additions to documentation labels Jun 12, 2024
@Winson-030 Winson-030 changed the title Update README Update README, deploy dify with YAML file on Kubernetes Jun 12, 2024
crazywoola
crazywoola requested changes Jun 13, 2024
View reviewed changes
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this to other languages as well :)

@Winson-030
Copy link
Contributor Author

No problem!

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jun 13, 2024
@Winson-030 Winson-030 requested a review from crazywoola June 13, 2024 23:05
@LeoQuote
Copy link
Contributor

IMHO Kubernetes manifests can be generated with helm template easily.

helm is providing a more user-friendly interface to configure app, users can easily upgrade dify to new version without reviewing thousands of lines yaml manifests.

helm can reuse many existing helm chart for components like minio, postgresql, those are well-maintained and can be upgraded easily.

The raw k8s manifest would contain thousands of lines of code with just a few parameter that needs user attention, and most of them are shared like database url, redis url etc, you would have to change them all if you want to customize your configuration.

Thus I would discourage using raw manifests as it’s not easy to maintain, I think this is an issue must be considered before merging this pr.

@Winson-030
Copy link
Contributor Author

IMHO Kubernetes manifests can be generated with helm template easily.

helm is providing a more user-friendly interface to configure app, users can easily upgrade dify to new version without reviewing thousands of lines yaml manifests.

helm can reuse many existing helm chart for components like minio, postgresql, those are well-maintained and can be upgraded easily.

The raw k8s manifest would contain thousands of lines of code with just a few parameter that needs user attention, and most of them are shared like database url, redis url etc, you would have to change them all if you want to customize your configuration.

Thus I would discourage using raw manifests as it’s not easy to maintain, I think this is an issue must be considered before merging this pr.

I did agree with you for these senerios, and this is why there are 2 community driven helm charts already, but YAML file is still necessary and needed for users who are not familar with helm and users who want to dive into seperate components.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 14, 2024
@crazywoola crazywoola merged commit 511ead4 into langgenius:main Jun 14, 2024
3 checks passed
dengpeng pushed a commit to dengpeng/dify that referenced this pull request Jun 16, 2024
@Winson-030 @dengpeng
Update README, deploy dify with YAML file on Kubernetes (langgenius#5131
db0b054 
)
Scorpion1221 added a commit to yybht155/dify that referenced this pull request Jun 26, 2024
@Scorpion1221
Merge commit '12c815c597b121357151c798aae6580304416937'
84db20b 
* commit '12c815c597b121357151c798aae6580304416937': (97 commits)
  fix: ExtractSetting optional value missing None as default val (langgenius#5238)
  version to 0.6.11 (langgenius#5224)
  Feat/firecrawl data source (langgenius#5232)
  update tooltip (langgenius#5235)
  fix: note editor italic (langgenius#5230)
  fix: z-index (langgenius#5229)
  Update README.md (langgenius#5228)
  fix: allow the name and icon of the web app to be set independently of that of the bot itself (langgenius#5225)
  fix: initialize site with customized icon and icon_background (langgenius#5227)
  feat: support firecrawl frontend code (langgenius#5226)
  feat(Tools): Add Feishu multi-dimensional table operation function (langgenius#5213)
  chore: development script for syncing Poetry lockfile (langgenius#5170)
  fix: workspace member's last_active should be last_active_time, but not last_login_time (langgenius#4906)
  fix: number variable cause type error in openai moderation (langgenius#5222)
  feat: new editor user permission profile (langgenius#4435)
  Fix: http_request delete method not working (langgenius#4975)
  Update README, deploy dify with YAML file on Kubernetes (langgenius#5131)
  feat: support tencent vector db (langgenius#3568)
  fix: add repo check for build-push.yml (langgenius#5141)
  feat: Add Optional API Key, Proxy Server, and Bypass Cache Parameters to Jina Tools (langgenius#5197)
  ...

# Conflicts:
#	api/core/helper/code_executor/code_executor.py
#	api/requirements.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

Assignees
No one assigned
Labels
📚 documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Winson-030 @LeoQuote @crazywoola