-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update model_provider jina to support custom url and model #4110
Conversation
I think we can just add the base URL and context size parameters directly on Jina Rerank, right? We can also add a switch for the context size, whether we need to customize it or not. |
It's a good suggues to add on jina rerank. |
703967f
to
4d222c3
Compare
@takatost I have update the code, please check again, thank you |
You're right, I mixed up the built-in models. 😅 |
Thanks, I'll test it later. |
Looks like the parameter `api_key` is missing here. sorry, it's forgot, I will add it later. |
Looks like the parameter `api_key` is missing here. I fixed it for you and also added custom model configuration for Embedding. 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks like the parameter `api_key` is missing here. Thank you so much. |
…ggenius#4110) Co-authored-by: Gimling <[email protected]> Co-authored-by: takatost <[email protected]>
…ggenius#4110) Co-authored-by: Gimling <[email protected]> Co-authored-by: takatost <[email protected]>
…ggenius#4110) Co-authored-by: Gimling <[email protected]> Co-authored-by: takatost <[email protected]>
Description
add jina_api_compatible to provide a method that user can add their rerank model
Fixes # (issue)
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsoptional
I have made corresponding changes to the documentationoptional
I have added tests that prove my fix is effective or that my feature worksoptional
New and existing unit tests pass locally with my changes