Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comfyui tool https #11859

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Conversation

shaxiaozz
Copy link
Contributor

@crazywoola Sorry, I missed one. When comfyui generates pictures, you also need to use websocket connection~

Summary

Fixes #11822
Because not all comfyui are deployed with dify, this part of the code currently has a check for "if comfyui is an https website, it cannot be successfully connected", so the judgment of the http protocol is added. If the comfyui website protocol is http, the websocket connection string is ws://, if the comfyui website protocol is https, then the websocket connection string is wss://.

Tip

Fixes #11822

Screenshots

Before:
This is an error before it is fixed. Regardless of the comfyui website protocol, ws:// will be used for websocket connectivity testing.
image

After:
This is after the repair, select the websocket connection string according to the comfyui website protocol
image

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Dec 19, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 20, 2024
@crazywoola crazywoola merged commit 95a7e50 into langgenius:main Dec 20, 2024
5 checks passed
jiangbo721 pushed a commit to jiangbo721/dify that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Comfyui tool cannot support HTTPS(WSS)
2 participants