Add DuckDuckGo News Search and Video Search #10703
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
crazywoola
reviewed
Nov 14, 2024
web/app/components/base/markdown.tsx
Outdated
| @@ -265,7 +265,7 @@ export function Markdown(props: { content: string; className?: string }) { | |||
| } | |||
| }, | |||
| ]} | |||
| disallowedElements={['script', 'iframe', 'head', 'html', 'meta', 'link', 'style', 'body']} | |||
| disallowedElements={['script', 'head', 'html', 'meta', 'link', 'style', 'body']} | |||
There was a problem hiding this comment.
As I said, I don't think this is a good idea to remove iframe from the markdown for now.
There was a problem hiding this comment.
The duckduckgo-video-search feature still works without removing iframe from markdown.tsx.
If keeping iframe, then users will get a video link or a list of video links.
Should I remove the changes in markdown.tsx?
Or can you just ignore the changes in markdown.tsx?
There was a problem hiding this comment.
Yes, please add iframe back, I shall approve this pr. And please fix the lint errors.
There was a problem hiding this comment.
I added it back. What's lint errors?
This was referenced Nov 15, 2024
loganclark360
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves #10665 (duckduckgo video search)
I also added duckduckgo news search.
Video Search
News Search