Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tool-node): introduce specific exceptions for tool node errors #10357

Merged

Conversation

laipz8200
Copy link
Collaborator

Checklist:

Important

Please review the checklist below before submitting your pull request.

Description

  • Created custom exception classes: ToolNodeError, ToolParameterError, and ToolFileError.
  • Replaced generic ValueError with specific custom exceptions in ToolNode operations.
  • Updated import paths for improved code modularity and exception handling.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

- Created custom exception classes: ToolNodeError, ToolParameterError, and ToolFileError.
- Replaced generic ValueError with specific custom exceptions in ToolNode operations.
- Updated import paths for improved code modularity and exception handling.
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 6, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 6, 2024
@laipz8200 laipz8200 merged commit 35d3da9 into main Nov 7, 2024
9 checks passed
@laipz8200 laipz8200 deleted the refactor/introduce-specific-exceptions-for-tool-node-errors branch November 7, 2024 06:02
AlwaysBluer pushed a commit to AlwaysBluer/dify that referenced this pull request Nov 14, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants