feat: Add updateHiddenOutputs helper function to manage output visibility #6932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…den outputs in the frontend CustomNodes module ♻️ (use-update-all-nodes.ts): refactor useUpdateAllNodes hook to update hidden outputs for all nodes in the frontend CustomNodes module ♻️ (use-update-node-code.ts): refactor useUpdateNodeCode hook to update hidden outputs for a specific node's code in the frontend CustomNodes module ♻️ (index.ts): refactor types in the flow module to include OutputFieldType for better type checking and consistency
dosubot
bot
added
size:M
github-actions
bot
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new helper function to update hidden outputs and integrates it into the existing codebase. The most important changes include the addition of the
updateHiddenOutputsfunction and its usage in relevant hooks.New Helper Function:
src/frontend/src/CustomNodes/helpers/update-hidden-outputs.ts: Added theupdateHiddenOutputsfunction to update the hidden status of outputs.Integration of Helper Function:
src/frontend/src/CustomNodes/hooks/use-update-all-nodes.ts: Imported theupdateHiddenOutputsfunction and used it to update the outputs within theuseUpdateAllNodeshook. [1] [2] [3]src/frontend/src/CustomNodes/hooks/use-update-node-code.ts: Imported theupdateHiddenOutputsfunction and used it to update the outputs within theuseUpdateNodeCodehook. [1] [2]Type Definitions:
src/frontend/src/types/flow/index.ts: AddedOutputFieldTypeto the type definitions and included an optionaloutputsfield in thenoteClassType. [1] [2]BEFORE UPDATING:
AFTER UPDATING:
The outputs remained hidden, whether using the single update button or the 'Update All' button.