fix: Text embedder caused by deprecated validation checks #6024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
github-actions
bot
added
bug
github-actions
bot
added
bug
edwinjosechittilappilly
requested review from
ogabrielluiz,
Cristhianzl and
italojohnny
github-actions
bot
added
bug
italojohnny
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the embedding generation process, fix import order, and clean up the codebase. The most important changes include combining validation checks, fixing import order in test files, and removing redundant code.
Improvements to embedding generation:
src/backend/base/langflow/components/embeddings/text_embedder.py: Combined validation checks for the embedding model to reduce nesting and removed redundant code for generating and validating embeddings.Partially closes:
#5636