Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing await to table check #5977

Merged
merged 1 commit into from
Jan 28, 2025
Merged

fix: add missing await to table check #5977

merged 1 commit into from
Jan 28, 2025

Conversation

ogabrielluiz
Copy link
Contributor

Convert the table check method to async to improve performance and responsiveness in the database service.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jan 28, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 28, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 28, 2025

CodSpeed Performance Report

Merging #5977 will improve performances by ×14

Comparing fix-migration-test (d881db6) with main (f49feef)

Summary

⚡ 1 improvements
✅ 8 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ test_build_flow 4,308.8 ms 302.9 ms ×14

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 28, 2025
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit 8e12ca4 Jan 28, 2025
35 of 42 checks passed
@ogabrielluiz ogabrielluiz deleted the fix-migration-test branch January 28, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@italojohnny italojohnny italojohnny approved these changes

@anovazzi1 anovazzi1 Awaiting requested review from anovazzi1

@Cristhianzl Cristhianzl Awaiting requested review from Cristhianzl

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ogabrielluiz @italojohnny