-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add minimized attribute to components and make chatinput and chatoutput start minimized by default #5374
Open
lucaseduoli
wants to merge
7
commits into
main
Choose a base branch
from
fix/chat_input_output_minimized
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Dec 19, 2024
github-actions
bot
added
bug
Something isn't working
and removed
enhancement
New feature or request
labels
Dec 19, 2024
github-actions
bot
added
bug
Something isn't working
and removed
bug
Something isn't working
labels
Dec 19, 2024
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
and removed
size:L
This PR changes 100-499 lines, ignoring generated files.
labels
Dec 19, 2024
github-actions
bot
added
bug
Something isn't working
and removed
bug
Something isn't working
labels
Dec 19, 2024
github-actions
bot
added
bug
Something isn't working
and removed
bug
Something isn't working
labels
Dec 19, 2024
CodSpeed Performance ReportMerging #5374 will improve performances by 58.12%Comparing Summary
Benchmarks breakdown
|
ogabrielluiz
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the formatting and functionality of chat components in the
langflow
backend. The most important changes include the addition of theminimized
attribute to bothChatInput
andChatOutput
classes, and the reformatting of code for better readability.Chat component enhancements:
src/backend/base/langflow/components/inputs/chat.py
: Added theminimized
attribute to theChatInput
class and reformatted imports and code blocks for better readability. [1] [2]src/backend/base/langflow/components/outputs/chat.py
: Added theminimized
attribute to theChatOutput
class and reformatted imports and code blocks for better readability. [1] [2] [3] [4]Attribute validation:
src/backend/base/langflow/custom/attributes.py
: Added theminimized
attribute to thegetattr_return_dict
function for validation.Starter project updates:
src/backend/base/langflow/initial_setup/starter_projects/Basic Prompt Chaining.json
: Updated theChatInput
andChatOutput
classes to include theminimized
attribute and reformatted the code for better readability. [1] [2]