fix: add data field to returned object on flowheader if flow is a component #5373
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g in flows.py - Consolidated import statements for better readability. - Updated the response structure in the function to utilize for improved data validation and consistency.
…nd validation - Updated FlowHeader model to include field descriptions for better clarity and documentation. - Introduced a model validator to ensure data integrity before processing. - Streamlined import statements for improved readability.
… is not a component
dosubot
bot
added
the
size:M
ogabrielluiz
requested changes
Dec 19, 2024
Comment on lines
229
to
234
| @model_validator(mode="before") | ||
| @classmethod | ||
| def validate_flow_header(cls, data: dict): | ||
| def validate_flow_header(cls, data: Flow): | ||
| if not data.is_component: | ||
| data.data = None | ||
| return data |
There was a problem hiding this comment.
This should be a field_validator for data. I don't think this should should work because data is a dict.
There was a problem hiding this comment.
I checked and data was returned as a Flow object. I considered it as a dict before and it didnt work
github-actions
bot
added
bug
dosubot
bot
added
size:XS
github-actions
bot
added
bug
CodSpeed Performance ReportMerging #5373 will degrade performances by 47.19%Comparing Summary
Benchmarks breakdown
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the code readability and functionality in the
langflowbackend. The most important changes include reformatting imports, updating theread_flowsfunction to useFlowHeader.model_validate, addingmodel_validatortoFlowHeader, and reformatting theFlowBaseandFlowclasses for better readability.Code readability improvements:
src/backend/base/langflow/api/v1/flows.py: Reformatted imports to a single line for better readability.src/backend/base/langflow/services/database/models/flow/model.py: Reformatted theFlowBaseandFlowclasses to improve readability by breaking long lines into multiple lines. [1] [2]Functionality improvements:
src/backend/base/langflow/api/v1/flows.py: Updated theread_flowsfunction to useFlowHeader.model_validatefor validating flow headers, simplifying the code.src/backend/base/langflow/services/database/models/flow/model.py: Addedmodel_validatorto theFlowHeaderclass to ensuredatais set toNoneifis_componentisFalse.Import enhancements:
src/backend/base/langflow/services/database/models/flow/model.py: Addedmodel_validatorimport frompydanticto support the new validation inFlowHeader.