Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjust path to run only unit tests #5184

Merged
merged 2 commits into from
Jan 8, 2025
Merged

fix: adjust path to run only unit tests #5184

merged 2 commits into from
Jan 8, 2025

Conversation

italojohnny
Copy link
Member

Adjusted the Makefile to run only unit tests and improved readability by splitting the test command into multiple lines

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 10, 2024
@italojohnny italojohnny enabled auto-merge (squash) December 10, 2024 14:04
@github-actions github-actions bot added the bug Something isn't working label Dec 10, 2024
ogabrielluiz
ogabrielluiz requested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not ideal because there are many unit tests that are not inside the unit folder. That's why it was set like this.

@italojohnny
Copy link
Member Author

This is not ideal because there are many unit tests that are not inside the unit folder. That's why it was set like this.

Pytest allows specifying multiple locations where the tests to be executed are stored.
I see two options:
Specify all the locations containing the unit tests, or
Move all unit tests to the unit folder.

@ogabrielluiz
Copy link
Contributor

ogabrielluiz commented Dec 11, 2024 •
edited
Loading

Moving them seems to be the better option.

@italojohnny italojohnny force-pushed the fix/makefile_unit_test branch from 3263b5d to ae6e5c6 Compare December 19, 2024 18:54
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Dec 19, 2024
anovazzi1
anovazzi1 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 7, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 7, 2025
@italojohnny italojohnny force-pushed the fix/makefile_unit_test branch from 0d6df0b to 33a5ba3 Compare January 8, 2025 13:38
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jan 8, 2025
@ogabrielluiz ogabrielluiz disabled auto-merge January 8, 2025 13:40
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit 93d5a22 Jan 8, 2025
10 checks passed
@ogabrielluiz ogabrielluiz deleted the fix/makefile_unit_test branch January 8, 2025 13:50
ogabrielluiz pushed a commit that referenced this pull request Jan 8, 2025
@italojohnny @ogabrielluiz
fix: adjust path to run only unit tests (#5184)
4729cda 
* fix: adjust path to run only unit tests

* style: split unit test command for readability
ogabrielluiz pushed a commit to raphaelchristi/langflow that referenced this pull request Jan 10, 2025
@italojohnny @ogabrielluiz
fix: adjust path to run only unit tests (langflow-ai#5184)
24a29be 
* fix: adjust path to run only unit tests

* style: split unit test command for readability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

@anovazzi1 anovazzi1 anovazzi1 approved these changes

@Cristhianzl Cristhianzl Awaiting requested review from Cristhianzl

@jordanrfrazier jordanrfrazier Awaiting requested review from jordanrfrazier

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@italojohnny @ogabrielluiz @anovazzi1