Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Agent): remove unused parameters #5172

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

raphaelchristi
Copy link
Contributor

This PR removes several unused and deprecated parameters to clean up the codebase:

Changes:

  • Remove JSON Mode from OpenAI component (redundant functionality)
  • Remove Schema (output_schema) from OpenAI component (deprecated)
  • Remove Model Kwargs from OpenAI component (unused)
  • Remove Output Parser from OpenAI component (non-functional)
  • Remove Verbose parameter from agent component (unused)

These changes simplify the components by removing parameters that were either deprecated, redundant, or not being used effectively.

- Remove JSON Mode from OpenAI component
- Remove Schema (output_schema) from OpenAI component
- Remove Model Kwargs from OpenAI component
- Remove Output Parser from OpenAI component
- Remove Verbose from agent component
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 9, 2024
@raphaelchristi raphaelchristi changed the title refactor(component): remove unused parameters refactor(Agent): remove unused parameters Dec 9, 2024
@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Dec 9, 2024
Copy link

codspeed-hq bot commented Dec 9, 2024

CodSpeed Performance Report

Merging #5172 will degrade performances by 27.74%

Comparing raphaelchristi:cleanup/agent-parameters (0ea9320) with main (b692ef7)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main raphaelchristi:cleanup/agent-parameters Change
test_get_and_cache_all_types_dict 1,043.8 µs 848 µs +23.09%
test_successful_run_with_input_type_text 329.1 ms 251.8 ms +30.71%
test_successful_run_with_output_type_any 177.2 ms 245.3 ms -27.74%

@edwinjosechittilappilly
Copy link
Collaborator

edwinjosechittilappilly commented Dec 18, 2024

When making changes in Agent Component, Please ensure that the changes in providers are tested.
Also Ensure the relevant code refactor is proprly handled in two different PR.

I suggest we have a different PR to remove irrelevant variables from Models and another PR to remove them from Agents.

We have seen issues that any changes in the model components should be tested with the agents; hence, I suggest having a separate PR to remove deprecated params from models (especially the ones used in the agents component).

Copy link
Collaborator

@edwinjosechittilappilly edwinjosechittilappilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Maintenance tasks and housekeeping size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants