Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swap descriptions for Load Data Flow and Retriever Flow in template #4814

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

mendonk
Copy link
Collaborator

@mendonk mendonk commented Nov 25, 2024

This pull request includes changes to the descriptions of nodes in the Vector Store RAG.json file to correct the order of steps in the flow. The most important changes include swapping the descriptions of the "Load Data Flow" and "Retriever Flow" nodes to ensure the correct sequence of operations.

Changes to node descriptions:

@mendonk mendonk self-assigned this Nov 25, 2024
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 25, 2024
@mendonk mendonk changed the title fix: swap descriptions for Load Data Flow and Retriever Flow in JSON … fix: swap descriptions for Load Data Flow and Retriever Flow in template Nov 25, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 25, 2024
Copy link

codspeed-hq bot commented Nov 25, 2024

CodSpeed Performance Report

Merging #4814 will degrade performances by 22.93%

Comparing fix-vector-rag-template-numbers (8d409c0) with main (450b371)

Summary

❌ 1 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix-vector-rag-template-numbers Change
test_successful_run_with_input_type_any 179.8 ms 233.3 ms -22.93%

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 25, 2024
@mendonk mendonk enabled auto-merge (squash) November 25, 2024 15:21
@mendonk mendonk merged commit aa73e6f into main Nov 25, 2024
33 of 34 checks passed
@mendonk mendonk deleted the fix-vector-rag-template-numbers branch November 25, 2024 15:25
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
…ate (langflow-ai#4814)

fix: swap descriptions for Load Data Flow and Retriever Flow in JSON configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants