fix: raise ImportError instead of silencing AttributeError #4812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
github-actions
bot
added
bug
italojohnny
force-pushed
the
chore/expose-import-errors
branch
from
8afa592 to
10c8514
Compare
ogabrielluiz
approved these changes
Nov 25, 2024
diogocabral
pushed a commit
to headlinevc/langflow
that referenced
this pull request
Nov 26, 2024
…ai#4812) * fix: raise ImportError instead of silencing AttributeError * chore: add Message class to init for import standardization * feat: add exception message pattern check for import errors * refactor: simplify code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR raises ImportError to prevent silencing of AttributeError during custom component evaluation and adds the Message class to init for easier, standardized imports