Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: updates import statements to use Pydantic in aiml_embeddings.py #4801

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This PR updates the import statements in aiml_embeddings.py to correctly reference Pydantic, ensuring compatibility and proper functionality of the code. The previous imports from langchain_core.pydantic_v1 have been replaced with direct imports from pydantic.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 23, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) November 23, 2024 22:15
@ogabrielluiz ogabrielluiz added the lgtm This PR has been approved by a maintainer label Nov 23, 2024
@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Nov 23, 2024
Copy link

codspeed-hq bot commented Nov 23, 2024

CodSpeed Performance Report

Merging #4801 will degrade performances by 16.95%

Comparing fix-aiml-imports (abbd906) with main (3e1b22b)

Summary

❌ 1 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix-aiml-imports Change
test_successful_run_with_output_type_any 257.9 ms 310.6 ms -16.95%

@ogabrielluiz ogabrielluiz force-pushed the fix-aiml-imports branch 2 times, most recently from 92ed44e to 9bfa890 Compare November 23, 2024 22:44
@ogabrielluiz ogabrielluiz merged commit bd15071 into main Nov 24, 2024
19 checks passed
@ogabrielluiz ogabrielluiz deleted the fix-aiml-imports branch November 24, 2024 08:25
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
…s.py (langflow-ai#4801)

Fix import statements for Pydantic in aiml_embeddings.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants