Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean invisible edge when toggling tool mode #4795

Merged
merged 3 commits into from
Nov 23, 2024

Conversation

lucaseduoli
Copy link
Collaborator

This pull request includes several changes to the FlowPage component and flowStore in the frontend. The primary focus is on removing unused functions and improving state management for nodes and edges.

Improvements to FlowPage component:

Enhancements to flowStore:

@lucaseduoli lucaseduoli self-assigned this Nov 22, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Nov 22, 2024
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 22, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 22, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 22, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The edge does not connect to the other component after it has been held by the mouse.

@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Nov 22, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 23, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) November 23, 2024 12:18
@ogabrielluiz ogabrielluiz merged commit 1120915 into main Nov 23, 2024
18 checks passed
@ogabrielluiz ogabrielluiz deleted the fix/invisible_edge branch November 23, 2024 12:53
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
* Fix invisible edges bug

* Removed elevate edges on select

* Fix style of reconnecting edge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants