-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: clean invisible edge when toggling tool mode #4795
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
This PR changes 0-9 lines, ignoring generated files.
bug
Something isn't working
labels
Nov 22, 2024
anovazzi1
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
github-actions
bot
added
bug
Something isn't working
and removed
bug
Something isn't working
labels
Nov 22, 2024
dosubot
bot
added
size:S
This PR changes 10-29 lines, ignoring generated files.
and removed
size:XS
This PR changes 0-9 lines, ignoring generated files.
labels
Nov 22, 2024
ogabrielluiz
requested changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The edge does not connect to the other component after it has been held by the mouse.
ogabrielluiz
approved these changes
Nov 23, 2024
ogabrielluiz
force-pushed
the
fix/invisible_edge
branch
from
November 23, 2024 12:15
6860adb
to
c53abb8
Compare
diogocabral
pushed a commit
to headlinevc/langflow
that referenced
this pull request
Nov 26, 2024
* Fix invisible edges bug * Removed elevate edges on select * Fix style of reconnecting edge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
FlowPage
component andflowStore
in the frontend. The primary focus is on removing unused functions and improving state management for nodes and edges.Improvements to
FlowPage
component:src/frontend/src/pages/FlowPage/components/PageComponent/index.tsx
: Removed the unusedcheckOldComponents
import.src/frontend/src/pages/FlowPage/components/PageComponent/index.tsx
: Removed theelevateEdgesOnSelect
property from the component props.Enhancements to
flowStore
:src/frontend/src/stores/flowStore.ts
: Removed the unusedcheckOldComponents
import.src/frontend/src/stores/flowStore.ts
: Added logic to clean edges when nodes are updated, ensuring the state remains consistent.src/frontend/src/stores/flowStore.ts
: Updated the store state to include the newly cleaned edges.