Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Minor style fixes #4578

Merged
merged 9 commits into from
Nov 13, 2024
Merged

refactor: Minor style fixes #4578

merged 9 commits into from
Nov 13, 2024

Conversation

deon-sanchez
Copy link
Collaborator

This pull request includes several updates to the frontend components, focusing on improving the user interface and adding new functionalities. The most important changes involve the HeaderMenu, PaginatorComponent, and Select components, as well as adjustments to the HeaderComponent and EmptyFolder elements.

User Interface Improvements:

New Functionalities:

Layout and Styling Enhancements:

- Refactor AccountMenu component to improve readability and simplify logic
- Update Select component to add support for direction prop and display ChevronUp icon when direction is set to "up"

Related work items: #4569, #4565
This commit refactors the header component in the MainPage to update its UI. It adds a sliding indicator for the view type (list or grid) and adjusts the styling of the buttons accordingly. It also removes commented out code related to the store button. Additionally, the commit updates the emptyFolder component by simplifying the text for the "New Flow" button.

Refactor the header component UI and update emptyFolder component
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 13, 2024
@deon-sanchez deon-sanchez self-assigned this Nov 13, 2024
@dosubot dosubot bot added the javascript Pull requests that update Javascript code label Nov 13, 2024
@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Nov 13, 2024
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 13, 2024
deon-sanchez and others added 4 commits November 13, 2024 16:50
- Refactor AccountMenu component to improve readability and simplify logic
- Update Select component to add support for direction prop and display ChevronUp icon when direction is set to "up"

Related work items: #4569, #4565
This commit refactors the header component in the MainPage to update its UI. It adds a sliding indicator for the view type (list or grid) and adjusts the styling of the buttons accordingly. It also removes commented out code related to the store button. Additionally, the commit updates the emptyFolder component by simplifying the text for the "New Flow" button.

Refactor the header component UI and update emptyFolder component
@ogabrielluiz ogabrielluiz merged commit 2b00041 into main Nov 13, 2024
18 checks passed
@ogabrielluiz ogabrielluiz deleted the minor-style-fixes branch November 13, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants