-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Minor style fixes #4578
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the header component in the MainPage to update its UI. It adds a sliding indicator for the view type (list or grid) and adjusts the styling of the buttons accordingly. It also removes commented out code related to the store button. Additionally, the commit updates the emptyFolder component by simplifying the text for the "New Flow" button. Refactor the header component UI and update emptyFolder component
dosubot
bot
added
the
size:M
This PR changes 30-99 lines, ignoring generated files.
label
Nov 13, 2024
ogabrielluiz
force-pushed
the
minor-style-fixes
branch
from
November 13, 2024 19:36
e8c55de
to
166e867
Compare
lucaseduoli
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This commit refactors the header component in the MainPage to update its UI. It adds a sliding indicator for the view type (list or grid) and adjusts the styling of the buttons accordingly. It also removes commented out code related to the store button. Additionally, the commit updates the emptyFolder component by simplifying the text for the "New Flow" button. Refactor the header component UI and update emptyFolder component
ogabrielluiz
force-pushed
the
minor-style-fixes
branch
from
November 13, 2024 19:50
d71931f
to
b03cb53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
javascript
Pull requests that update Javascript code
lgtm
This PR has been approved by a maintainer
refactor
Maintenance tasks and housekeeping
size:M
This PR changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the frontend components, focusing on improving the user interface and adding new functionalities. The most important changes involve the
HeaderMenu
,PaginatorComponent
, andSelect
components, as well as adjustments to theHeaderComponent
andEmptyFolder
elements.User Interface Improvements:
src/frontend/src/components/appHeaderComponent/components/HeaderMenu/index.tsx
: Updated theHeaderMenuItemLink
andHeaderMenuItemButton
components to include new transition effects and improved icon positioning. [1] [2]New Functionalities:
src/frontend/src/components/paginatorComponent/index.tsx
: Added adirection
prop to theSelectTrigger
component, allowing the dropdown to open upwards.src/frontend/src/components/ui/select.tsx
: ImportedChevronUp
icon and updated theSelectTrigger
component to use thedirection
prop for dynamic icon rendering. [1] [2] [3]Layout and Styling Enhancements:
src/frontend/src/pages/MainPage/components/header/index.tsx
: Added a sliding indicator to the view toggle buttons and removed unused store navigation tooltip. [1] [2]src/frontend/src/pages/MainPage/pages/emptyFolder/index.tsx
: Simplified the styling of the "New Flow" button for better readability.src/frontend/src/pages/MainPage/pages/homePage/index.tsx
: Removed outdated comments related to the DataStax Langflow preview banner.