Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: process.py to use validate_and_repair_json from utils.py #4576

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

anovazzi1
Copy link
Contributor

This pull request refactors the process.py file to use the validate_and_repair_json function from the utils.py file for nested dictionary tweaks. The apply_tweaks function now checks if the tweak value is a nested dictionary and calls validate_and_repair_json to validate and repair the JSON string if necessary. This ensures that the JSON string is valid and can be parsed correctly.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 13, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 13, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 13, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) November 13, 2024 18:44
Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #4576 will degrade performances by 37.81%

Comparing fixTweaks (e00c49c) with main (563b90e)

Summary

❌ 1 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fixTweaks Change
test_successful_run_with_input_type_text 127.5 ms 205.1 ms -37.81%

@ogabrielluiz ogabrielluiz merged commit 34b107b into main Nov 13, 2024
38 of 39 checks passed
@ogabrielluiz ogabrielluiz deleted the fixTweaks branch November 13, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants