Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Astra DB Graph Vector Store langchain 0.3.x #4568

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

erichare
Copy link
Collaborator

This pull request updates the construct of the Graph Vector Store to pass parameters correctly in the event of missing metadata exclusion or other params, to maintain compatibility with langchain 0.3.x

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Nov 13, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 13, 2024
@erichare erichare enabled auto-merge (squash) November 13, 2024 14:32
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 13, 2024
@erichare erichare merged commit 3a73e01 into main Nov 13, 2024
34 of 36 checks passed
@erichare erichare deleted the fix-astradb-graph-vs branch November 13, 2024 14:37
Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #4568 will degrade performances by 92.43%

Comparing fix-astradb-graph-vs (5c1f45f) with main (151c369)

Summary

❌ 3 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix-astradb-graph-vs Change
test_build_flow_from_request_data 408.4 ms 5,395.4 ms -92.43%
test_successful_run_with_input_type_any 127.6 ms 205.2 ms -37.81%
test_successful_run_with_input_type_text 182.7 ms 205.1 ms -10.92%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants