Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aws components and model lists #4560

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

edwinjosechittilappilly
Copy link
Collaborator

This pull request includes updates to the AWS model IDs and the AmazonBedrockEmbeddingsComponent class to enhance the organization and functionality of the codebase. The most important changes include the addition of new model IDs, the removal of certain models, and the introduction of a new constant for embedding model IDs.

Updates to AWS model IDs:

Enhancements to AmazonBedrockEmbeddingsComponent:

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 13, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 13, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 13, 2024
Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #4560 will degrade performances by 92.56%

Comparing fix-remove-image-models-aws (be5db98) with main (8d89bf4)

Summary

❌ 3 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix-remove-image-models-aws Change
test_build_flow_from_request_data 402.5 ms 5,412.3 ms -92.56%
test_invalid_run_with_input_type_chat 13.8 ms 16.4 ms -15.76%
test_successful_run_with_input_type_any 197.9 ms 221 ms -10.42%

removed image models,
It was removed earlier but some PR Messed up the list again.
image embedd removed
@edwinjosechittilappilly edwinjosechittilappilly merged commit 5bb588c into main Nov 13, 2024
19 checks passed
@edwinjosechittilappilly edwinjosechittilappilly deleted the fix-remove-image-models-aws branch November 13, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants