Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add session_id and graph parameters to flow execution functions and update graph init in Flow as Tool #4558

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This pull request enhances the FlowTool and related components by introducing session_id and graph parameters to flow execution functions. The changes improve the context management during graph creation and execution, allowing for better tracking of user sessions and flow states. Additionally, the graph initialization logic has been updated to accommodate these new parameters, ensuring a more robust and flexible flow execution process.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 13, 2024
@ogabrielluiz ogabrielluiz changed the title fix: eAdd session_id and graph parameters to flow execution functions fix: Add session_id and graph parameters to flow execution functions Nov 13, 2024
@dosubot dosubot bot added the enhancement New feature or request label Nov 13, 2024
@ogabrielluiz ogabrielluiz changed the title fix: Add session_id and graph parameters to flow execution functions fix: Add session_id and graph parameters to flow execution functions and update graph init in Flow as Tool Nov 13, 2024
@github-actions github-actions bot added bug Something isn't working and removed enhancement New feature or request bug Something isn't working labels Nov 13, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 13, 2024
Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #4558 will degrade performances by 20.67%

Comparing flow-as-tool-fix (78453dc) with main (f1fd5be)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main flow-as-tool-fix Change
test_invalid_run_with_input_type_chat 13.6 ms 15.1 ms -10.01%
test_successful_run_with_input_type_any 205 ms 129.5 ms +58.27%
test_successful_run_with_output_type_any 162.3 ms 204.6 ms -20.67%

@ogabrielluiz ogabrielluiz merged commit f978223 into main Nov 13, 2024
18 of 25 checks passed
@ogabrielluiz ogabrielluiz deleted the flow-as-tool-fix branch November 13, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants