Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new starter projects and replace old ones #4557

Merged
merged 9 commits into from
Nov 13, 2024
Merged

Conversation

anovazzi1
Copy link
Contributor

This pull request updates the templates used in the new flow modal

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. enhancement New feature or request labels Nov 13, 2024
@NadirJ NadirJ self-requested a review November 13, 2024 00:46
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 13, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some tests require these. I'm not sure removing them is a good idea.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we do not remove them they will be avaliable in the examples

@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Nov 13, 2024
@ogabrielluiz ogabrielluiz changed the title feature: Update templates feat: add new starter projects and replace old ones Nov 13, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Nov 13, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 13, 2024
@ogabrielluiz ogabrielluiz merged commit f1fd5be into main Nov 13, 2024
9 of 27 checks passed
@ogabrielluiz ogabrielluiz deleted the UpdateExamples branch November 13, 2024 02:46
Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #4557 will degrade performances by 29.09%

Comparing UpdateExamples (82eb0e8) with main (8e0d6d5)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main UpdateExamples Change
test_create_starter_projects 462.7 ms 652.4 ms -29.09%
test_invalid_run_with_input_type_chat 16.8 ms 13.7 ms +22.61%
test_successful_run_with_output_type_debug 405.2 ms 455 ms -10.94%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants