-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Agent Component update_build_config, Nvidia and other model dynamic parameter loading #4556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
This PR changes 30-99 lines, ignoring generated files.
label
Nov 13, 2024
CodSpeed Performance ReportMerging #4556 will degrade performances by 29.59%Comparing Summary
Benchmarks breakdown
|
NadirJ
approved these changes
Nov 13, 2024
ogabrielluiz
force-pushed
the
fix_agent_update_config
branch
from
November 13, 2024 01:40
abf0e2c
to
09de0fc
Compare
added support for dynamic models.
ogabrielluiz
force-pushed
the
fix_agent_update_config
branch
from
November 13, 2024 01:40
09de0fc
to
64bfc84
Compare
@ogabrielluiz @anovazzi1 can you check why a lot of frontend test are failing in this PR? |
@edwinjosechittilappilly it is due to changes in templates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on simplifying the handling of input field prefixes and enhancing the update logic for build configurations within the
agent.py
file. The most important changes include removing prefixes from input field names and updating the build configuration logic to be more modular and maintainable.Simplification of Input Field Prefixes:
src/backend/base/langflow/base/models/model_input_constants.py
: Removed prefixes from input field names in thecreate_input_fields_dict
function and updated related dictionary entries accordingly. [1] [2] [3]Enhancements to Build Configuration Logic:
src/backend/base/langflow/components/agents/agent.py
: Added logic to call theupdate_build_config
method of component classes if they exist, ensuring that the build configuration is updated correctly based on the selected provider. [1] [2] [3] [4]