Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Agent Component update_build_config, Nvidia and other model dynamic parameter loading #4556

Merged
merged 6 commits into from
Nov 13, 2024

Conversation

edwinjosechittilappilly
Copy link
Collaborator

This pull request focuses on simplifying the handling of input field prefixes and enhancing the update logic for build configurations within the agent.py file. The most important changes include removing prefixes from input field names and updating the build configuration logic to be more modular and maintainable.

Simplification of Input Field Prefixes:

Enhancements to Build Configuration Logic:

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 13, 2024
Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #4556 will degrade performances by 29.59%

Comparing fix_agent_update_config (40e3b28) with main (f978223)

Summary

⚡ 1 improvements
❌ 3 regressions
✅ 11 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix_agent_update_config Change
test_invalid_run_with_input_type_chat 13.8 ms 16.4 ms -15.79%
test_successful_run_with_input_type_any 204.6 ms 136.8 ms +49.55%
test_successful_run_with_output_type_any 135.2 ms 192 ms -29.59%
test_successful_run_with_output_type_debug 204.5 ms 231.3 ms -11.56%

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 13, 2024
@edwinjosechittilappilly
Copy link
Collaborator Author

@ogabrielluiz @anovazzi1 can you check why a lot of frontend test are failing in this PR?

@ogabrielluiz
Copy link
Contributor

@edwinjosechittilappilly it is due to changes in templates

@ogabrielluiz ogabrielluiz merged commit 7b78a16 into main Nov 13, 2024
4 checks passed
@ogabrielluiz ogabrielluiz deleted the fix_agent_update_config branch November 13, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants