refactor: increase search sensitivity and simplify metadata filtering in FlowSidebarComponent #4546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…consider item metadata for search 🔧 (index.tsx): Adjust search threshold value to improve search accuracy
dosubot
bot
added
size:XS
ogabrielluiz
changed the title
ogabrielluiz
approved these changes
Nov 13, 2024
github-actions
bot
added
refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on refining the search functionality in the
FlowSidebarComponentby adjusting the search threshold and modifying the traditional search metadata filtering logic.Improvements to search functionality:
src/frontend/src/pages/FlowPage/components/flowSidebarComponent/index.tsx: Adjusted the search threshold in theFlowSidebarComponentfrom0.3to0.2to make the search more sensitive.src/frontend/src/pages/FlowPage/components/flowSidebarComponent/index.tsx: Removed an unnecessary blank line in theFlowSidebarComponentto improve code readability.Refinement to traditional search metadata:
src/frontend/src/pages/FlowPage/components/flowSidebarComponent/helpers/traditional-search-metadata.ts: Simplified the filtering logic intraditionalSearchMetadataby removing redundant conditions and focusing on metadata search.