-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor settings page to use new sidebar and fix old bugs #4545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
javascript
Pull requests that update Javascript code
labels
Nov 12, 2024
Cristhianzl
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
CodSpeed Performance ReportMerging #4545 will degrade performances by 21.01%Comparing Summary
Benchmarks breakdown
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
javascript
Pull requests that update Javascript code
lgtm
This PR has been approved by a maintainer
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various changes to the frontend components, primarily focused on refactoring the sidebar components, improving layout styles, and updating the sidebar context. The most important changes are grouped into three themes: Sidebar Component Refactoring, Page Layout Updates, and Sidebar Context Enhancements.
Sidebar Component Refactoring:
SideBarButtonsComponent
fromsrc/frontend/src/components/sidebarComponent/components/sideBarButtons/index.tsx
and integrated its functionality intosrc/frontend/src/components/sidebarComponent/index.tsx
. [1] [2]FolderSidebarNav
andSettingsPage
to use the newSideBarButtonsComponent
structure. [1] [2]Page Layout Updates:
PageLayout
to improve layout consistency across different screen sizes. [1] [2]GeneralPage
component to handle overflow-x for better layout management.Sidebar Context Enhancements:
defaultOpen
property to theSidebarContext
and updated related logic insidebar.tsx
to handle the sidebar's default state based on the collapsible property. [1] [2] [3]OldHomePage
andSettingsPage
components withSidebarProvider
to manage sidebar state and behavior more effectively. [1] [2] [3]