feat(input): Add drag prevention to popover and improve icon fallback handling #4544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to prevent dragging 📝 (index.tsx): provide default icon name 'ChevronsUpDown' if getIconName function returns falsy value
dosubot
bot
added
size:S
github-actions
bot
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
inputComponentto enhance functionality and improve the user interface. The most important changes involve adding a new class to the popover input and modifying the icon name handling.User Interface Improvements:
src/frontend/src/components/inputComponent/components/popover/index.tsx: Added thenodragclass to thepopover-inputelement to prevent drag interactions.Functionality Enhancements:
src/frontend/src/components/inputComponent/index.tsx: Modified thenameproperty ofForwardedIconComponentto ensure a default icon (ChevronsUpDown) is used whengetIconNamereturnsnull.