Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aws bedrock load db credentials issue #4537

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

edwinjosechittilappilly
Copy link
Collaborator

This pull request includes changes to the AmazonBedrockEmbeddingsComponent and AmazonBedrockComponent classes to update the configuration of AWS session tokens and credentials profiles.

Changes to AWS session token configuration:

Changes to AWS credentials profile configuration:

error: When load_from_db is False No value need to be provided for SecretStr.
If value provided it would show an error.
session token  suggested to be required in updated new credentials hence making it advanced=False
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 12, 2024
@edwinjosechittilappilly
Copy link
Collaborator Author

@ogabrielluiz
If necessary, we can move the session token to the advanced section. However, based on feedback from LF, we noted that several users frequently require the session token field, so we will keep it accessible and not move it to advanced.

Additionally, I have removed the default value in cases where the load from the database is set to False.

@github-actions github-actions bot added the bug Something isn't working label Nov 12, 2024
Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #4537 will improve performances by 16.67%

Comparing fix-aws-bedrock-load-db-cred (ae24829) with main (70ebfc4)

Summary

⚡ 1 improvements
✅ 14 untouched benchmarks

Benchmarks breakdown

Benchmark main fix-aws-bedrock-load-db-cred Change
test_successful_run_with_input_type_any 532.1 ms 456.1 ms +16.67%

Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
@ogabrielluiz ogabrielluiz merged commit 01431ee into main Nov 12, 2024
29 checks passed
@ogabrielluiz ogabrielluiz deleted the fix-aws-bedrock-load-db-cred branch November 12, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants