-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: aws bedrock load db credentials issue #4537
Conversation
error: When load_from_db is False No value need to be provided for SecretStr. If value provided it would show an error.
session token suggested to be required in updated new credentials hence making it advanced=False
@ogabrielluiz Additionally, I have removed the default value in cases where the load from the database is set to False. |
CodSpeed Performance ReportMerging #4537 will improve performances by 16.67%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request includes changes to the
AmazonBedrockEmbeddingsComponent
andAmazonBedrockComponent
classes to update the configuration of AWS session tokens and credentials profiles.Changes to AWS session token configuration:
src/backend/base/langflow/components/embeddings/amazon_bedrock.py
: Changed theadvanced
attribute of theaws_session_token
input fromTrue
toFalse
to make it a non-advanced setting.src/backend/base/langflow/components/models/amazon_bedrock.py
: Changed theadvanced
attribute of theaws_session_token
input fromTrue
toFalse
, removed thevalue
attribute, and setload_from_db
toFalse
.Changes to AWS credentials profile configuration:
src/backend/base/langflow/components/models/amazon_bedrock.py
: Removed thevalue
attribute from theAWS_CREDENTIALS_PROFILE_NAME
input to simplify the configuration.