Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update error handling in request for litellm models #4536

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

phact
Copy link
Collaborator

@phact phact commented Nov 12, 2024

Handle request exception for litellm models.

This pull request introduces error handling for network requests and JSON parsing in the astra_assistants/util.py file. The most important changes include importing necessary exceptions and adding try-except blocks to handle potential errors.

Error handling improvements:

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Nov 12, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 12, 2024
Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #4536 will degrade performances by 14.38%

Comparing offline-startup (9099dcf) with main (f8f9b7c)

Summary

❌ 1 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main offline-startup Change
test_successful_run_with_input_type_any 455.7 ms 532.2 ms -14.38%

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
@phact phact enabled auto-merge (squash) November 12, 2024 19:28
@phact phact self-assigned this Nov 12, 2024
@ogabrielluiz ogabrielluiz changed the title fix: offline startup fix: update error handling in request for litellm models Nov 13, 2024
@ogabrielluiz ogabrielluiz merged commit 168c716 into main Nov 13, 2024
24 of 27 checks passed
@ogabrielluiz ogabrielluiz deleted the offline-startup branch November 13, 2024 01:23
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants