refactor: Update AccountMenu and HeaderMenu components #4534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update AccountMenu component to conditionally render CustomHeaderMenuItemsTitle - Update HeaderMenu component to adjust styling and class names
deon-sanchez
added
javascript
dosubot
bot
added
the
size:M
…mport-home-nav-updates
github-actions
bot
added
refactor
lucaseduoli
requested changes
Nov 12, 2024
src/frontend/src/components/appHeaderComponent/components/HeaderMenu/index.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
appHeaderComponentand related components to improve the layout and conditional rendering based on theENABLE_DATASTAX_LANGFLOWfeature flag. The most important changes include modifications to theAccountMenu,HeaderMenu, andAppHeadercomponents, as well as updates to theHomePage.Changes to Layout and Styling:
src/frontend/src/components/appHeaderComponent/components/AccountMenu/index.tsx: Updated class names for styling improvements and added conditional rendering forCustomHeaderMenuItemsTitleandThemeButtonsbased on theENABLE_DATASTAX_LANGFLOWfeature flag.src/frontend/src/components/appHeaderComponent/components/HeaderMenu/index.tsx: Modified class names forHeaderMenuToggle,HeaderMenuItemLink, andHeaderMenuItemsto improve layout and styling. [1] [2] [3]src/frontend/src/components/ui/dropdown-menu.tsx: Added margin toDropdownMenuContentfor better spacing.Conditional Rendering Based on Feature Flag:
src/frontend/src/components/appHeaderComponent/index.tsx: Updated theAppHeadercomponent to conditionally render elements based on theENABLE_DATASTAX_LANGFLOWfeature flag, including changes to the left section, middle section, and additional buttons. [1] [2] [3] [4] [5] [6] [7]src/frontend/src/pages/MainPage/pages/homePage/index.tsx: Added a custom banner forDataStax Langflowwhen the feature flag is enabled and removed the old commented-out banner code. [1] [2]- Update AccountMenu component to conditionally render CustomHeaderMenuItemsTitle