Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added model utils to get the model name #4532

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

edwinjosechittilappilly
Copy link
Collaborator

This pull request introduces a new utility function to extract the model name from a language model object and integrates this function into the agent component to enhance model handling.

Key changes include:

New Utility Function:

Integration of Utility Function:

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 12, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 12, 2024
Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #4532 will improve performances by 22.93%

Comparing fix-model-name-agents-playground (72b2315) with main (da833a5)

Summary

⚡ 3 improvements
✅ 12 untouched benchmarks

Benchmarks breakdown

Benchmark main fix-model-name-agents-playground Change
test_successful_run_with_input_type_text 554.3 ms 455.5 ms +21.7%
test_successful_run_with_output_type_any 455 ms 370.1 ms +22.93%
test_successful_run_with_output_type_debug 455.5 ms 409 ms +11.37%

Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about adding tests for this function using a few llm components?

@edwinjosechittilappilly
Copy link
Collaborator Author

What do you think about adding tests for this function using a few llm components?

Sure!
should we add it now? or after this release?

@ogabrielluiz ogabrielluiz force-pushed the fix-model-name-agents-playground branch from df00c80 to 72b2315 Compare November 13, 2024 01:25
@ogabrielluiz ogabrielluiz merged commit da833a5 into main Nov 13, 2024
4 checks passed
@ogabrielluiz ogabrielluiz deleted the fix-model-name-agents-playground branch November 13, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants