Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: KeyError in Langchain Hub component #4530

Merged
merged 9 commits into from
Nov 12, 2024
Merged

fix: KeyError in Langchain Hub component #4530

merged 9 commits into from
Nov 12, 2024

Conversation

erichare
Copy link
Collaborator

This pull request fixes a reported bug about the Langchain Hub Component being incompatible with messages piped in from other components.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 12, 2024
@dosubot dosubot bot added the bug Something isn't working label Nov 12, 2024
@github-actions github-actions bot removed the bug Something isn't working label Nov 12, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 12, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 12, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 12, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4530 will degrade performances by 86.36%

Comparing bugfix-langchain-hub-inputs (1e3f82d) with main (1dfa160)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main bugfix-langchain-hub-inputs Change
❌ test_build_flow_from_request_data 788.1 ms 5,778.6 ms -86.36%
❌ test_successful_run_with_input_type_text 394 ms 454.6 ms -13.32%
⚡ test_successful_run_with_output_type_debug 531.8 ms 455.4 ms +16.77%

@erichare erichare enabled auto-merge (squash) November 12, 2024 16:25
@erichare @ogabrielluiz
Update src/backend/base/langflow/components/langchain_utilities/langc…
54294f0 
…hain_hub.py

Co-authored-by: Gabriel Luiz Freitas Almeida <[email protected]>
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 12, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 12, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
@erichare erichare merged commit be44183 into main Nov 12, 2024
29 checks passed
@erichare erichare deleted the bugfix-langchain-hub-inputs branch November 12, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

@carlosrcoelho carlosrcoelho Awaiting requested review from carlosrcoelho

@Cristhianzl Cristhianzl Awaiting requested review from Cristhianzl

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erichare @ogabrielluiz