-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: reorganize memory components and enhance model inputs with improved documentation #4529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
documentation
Improvements or additions to documentation
labels
Nov 12, 2024
CodSpeed Performance ReportMerging #4529 will degrade performances by 22.23%Comparing Summary
Benchmarks breakdown
|
dosubot
bot
added
size:S
This PR changes 10-29 lines, ignoring generated files.
and removed
size:L
This PR changes 100-499 lines, ignoring generated files.
labels
Nov 12, 2024
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
and removed
size:S
This PR changes 10-29 lines, ignoring generated files.
labels
Nov 12, 2024
lucaseduoli
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ogabrielluiz
force-pushed
the
cz/components-changes
branch
from
November 13, 2024 03:38
14e057c
to
4a5b8ce
Compare
…mponent as legacy code
…t is no longer in beta 📝 (extract_key.py): remove beta flag from ExtractDataKeyComponent to indicate it is no longer in beta
…eld to indicate it is an advanced setting
…rrect component names for better clarity and maintainability ♻️ (freeze.spec.ts): Refactor test to use the correct component name for consistency and readability ♻️ (stop-building.spec.ts): Refactor test to use the correct component name for consistency and readability ♻️ (generalBugs-shard-9.spec.ts): Refactor test to use the correct component name for consistency and readability ♻️ (filterEdge-shard-1.spec.ts): Refactor test to use the correct component name for consistency and readability
…lity Enhance clarity in the component's purpose and refine inline formatting to boost maintainability.
ogabrielluiz
force-pushed
the
cz/components-changes
branch
from
November 13, 2024 03:46
4a5b8ce
to
1477604
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
lgtm
This PR has been approved by a maintainer
size:M
This PR changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various updates and improvements to the
langflow
backend components. The most important changes involve reorganization of memory components, enhancements to model inputs, and updates to the initial setup for starter projects.Memory Components Reorganization:
Mem0MemoryComponent
frommem0
tomemories
and updated imports accordingly. (src/backend/base/langflow/components/memories/__init__.py
,src/backend/base/langflow/components/mem0/__init__.py
) [1] [2] [3]Model Input Enhancements:
LCModelComponent
base inputs inollama.py
for better clarity and addedadvanced=True
to theverbose
input. (src/backend/base/langflow/components/models/ollama.py
) [1] [2] [3]Starter Projects Updates:
info
fields to various inputs inAgent Flow.json
to improve user guidance. (src/backend/base/langflow/initial_setup/starter_projects/Agent Flow.json
) [1] [2] [3]Component Metadata Updates:
ExtractDataKeyComponent
andSelectDataComponent
as legacy components. (src/backend/base/langflow/components/processing/extract_key.py
,src/backend/base/langflow/components/processing/select_data.py
) [1] [2]Documentation and Descriptions:
WebhookComponent
,WolframAlphaAPIComponent
, andYahooFinanceToolComponent
for better clarity. (src/backend/base/langflow/components/data/webhook.py
,src/backend/base/langflow/components/tools/wolfram_alpha_api.py
,src/backend/base/langflow/components/tools/yahoo_finance.py
) [1] [2] [3]