Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reorganize memory components and enhance model inputs with improved documentation #4529

Merged
merged 16 commits into from
Nov 13, 2024

Conversation

Cristhianzl
Copy link
Collaborator

This pull request includes various updates and improvements to the langflow backend components. The most important changes involve reorganization of memory components, enhancements to model inputs, and updates to the initial setup for starter projects.

Memory Components Reorganization:

  • Moved Mem0MemoryComponent from mem0 to memories and updated imports accordingly. (src/backend/base/langflow/components/memories/__init__.py, src/backend/base/langflow/components/mem0/__init__.py) [1] [2] [3]

Model Input Enhancements:

  • Reordered LCModelComponent base inputs in ollama.py for better clarity and added advanced=True to the verbose input. (src/backend/base/langflow/components/models/ollama.py) [1] [2] [3]

Starter Projects Updates:

  • Added detailed info fields to various inputs in Agent Flow.json to improve user guidance. (src/backend/base/langflow/initial_setup/starter_projects/Agent Flow.json) [1] [2] [3]

Component Metadata Updates:

  • Marked ExtractDataKeyComponent and SelectDataComponent as legacy components. (src/backend/base/langflow/components/processing/extract_key.py, src/backend/base/langflow/components/processing/select_data.py) [1] [2]

Documentation and Descriptions:

  • Updated descriptions for WebhookComponent, WolframAlphaAPIComponent, and YahooFinanceToolComponent for better clarity. (src/backend/base/langflow/components/data/webhook.py, src/backend/base/langflow/components/tools/wolfram_alpha_api.py, src/backend/base/langflow/components/tools/yahoo_finance.py) [1] [2] [3]

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. documentation Improvements or additions to documentation labels Nov 12, 2024
Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #4529 will degrade performances by 22.23%

Comparing cz/components-changes (1477604) with main (f978223)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main cz/components-changes Change
test_successful_run_with_input_type_text 205.1 ms 144.6 ms +41.86%
test_successful_run_with_output_type_any 135.2 ms 173.8 ms -22.23%

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 12, 2024
@Cristhianzl Cristhianzl self-assigned this Nov 12, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 12, 2024
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
@lucaseduoli lucaseduoli enabled auto-merge (squash) November 12, 2024 17:49
@Cristhianzl Cristhianzl enabled auto-merge (squash) November 12, 2024 18:13
@Cristhianzl Cristhianzl removed the request for review from ogabrielluiz November 12, 2024 19:54
Cristhianzl and others added 2 commits November 13, 2024 00:46
…rrect component names for better clarity and maintainability

♻️ (freeze.spec.ts): Refactor test to use the correct component name for consistency and readability
♻️ (stop-building.spec.ts): Refactor test to use the correct component name for consistency and readability
♻️ (generalBugs-shard-9.spec.ts): Refactor test to use the correct component name for consistency and readability
♻️ (filterEdge-shard-1.spec.ts): Refactor test to use the correct component name for consistency and readability
…lity

Enhance clarity in the component's purpose and refine inline formatting to boost maintainability.
@ogabrielluiz ogabrielluiz merged commit 8d89bf4 into main Nov 13, 2024
23 of 28 checks passed
@ogabrielluiz ogabrielluiz deleted the cz/components-changes branch November 13, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants