Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to deactivate tracing in service settings #4527

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This pull request introduces a new setting to deactivate tracing within the service settings, allowing for more flexible testing and configuration. Additionally, a fixture has been added to automatically deactivate tracing in tests using monkeypatch, ensuring that tracing does not interfere with test outcomes.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Nov 12, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Nov 12, 2024
Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #4527 will improve performances by ×2.2

Comparing tracing-deactivate-option (a7476ec) with main (2ddd773)

Summary

⚡ 6 improvements
✅ 9 untouched benchmarks

Benchmarks breakdown

Benchmark main tracing-deactivate-option Change
test_build_flow 711.9 ms 374.3 ms +90.22%
test_build_flow_from_request_data 788.7 ms 394.1 ms ×2
test_successful_run_with_input_type_any 455.8 ms 205.3 ms ×2.2
test_successful_run_with_input_type_text 367.4 ms 205.3 ms +78.9%
test_successful_run_with_output_type_any 455.4 ms 204.6 ms ×2.2
test_successful_run_with_output_type_debug 453.8 ms 204.7 ms ×2.2

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
@NadirJ NadirJ self-requested a review November 13, 2024 02:39
@ogabrielluiz ogabrielluiz merged commit 7c0c881 into main Nov 13, 2024
37 of 45 checks passed
@ogabrielluiz ogabrielluiz deleted the tracing-deactivate-option branch November 13, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants