Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tools as requried=False in Agents #4525

Merged
merged 8 commits into from
Nov 12, 2024

Conversation

edwinjosechittilappilly
Copy link
Collaborator

This pull request includes a change to the LCToolsAgentComponent class in the agent.py file. The change modifies the required attribute of the input_types parameter from True to False.

tools as not required by default.
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 12, 2024
@edwinjosechittilappilly
Copy link
Collaborator Author

Hi Gabriel,
can I change tools required= False in LCToolsAgentComponent
Or should we change it by overriding it just in AgentComponent?

@github-actions github-actions bot added the bug Something isn't working label Nov 12, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #4525 will improve performances by 14.36%

Comparing fix-agent-component-tools (42434da) with main (145d67f)

Summary

⚡ 1 improvements
✅ 14 untouched benchmarks

Benchmarks breakdown

Benchmark main fix-agent-component-tools Change
test_successful_run_with_input_type_any 520.4 ms 455 ms +14.36%

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 12, 2024
@edwinjosechittilappilly
Copy link
Collaborator Author

cc. @ogabrielluiz
pytest updated to use Agent Component.

@edwinjosechittilappilly edwinjosechittilappilly merged commit aca2b4b into main Nov 12, 2024
29 checks passed
@edwinjosechittilappilly edwinjosechittilappilly deleted the fix-agent-component-tools branch November 12, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants