fix: Refactor DataFilterComponent inputs #4524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
CodSpeed Performance ReportMerging #4524 will degrade performances by 14.46%Comparing Summary
Benchmarks breakdown
|
ogabrielluiz
requested changes
Nov 12, 2024
There was a problem hiding this comment.
Also, you can use the Component tests with this one. We can merge it after #4526
| ), | ||
| MessageInput( | ||
| StrInput( |
There was a problem hiding this comment.
Suggested change
| StrInput( | |
| MessageTextInput( |
| @@ -1,7 +1,7 @@ | |||
| from typing import Any | |||
|
|
|||
| from langflow.custom import Component | |||
| from langflow.io import DataInput, DropdownInput, MessageInput, Output | |||
| from langflow.io import DataInput, DropdownInput, Output, StrInput | |||
There was a problem hiding this comment.
Suggested change
| from langflow.io import DataInput, DropdownInput, Output, StrInput | |
| from langflow.io import DataInput, DropdownInput, Output, MessageTextInput |
…nstead of StrInput
ogabrielluiz
force-pushed
the
updateDataFilterComponent
branch
from
6edf51d
to
84c12f6
Compare
ogabrielluiz
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the inputs of the DataFilterComponent to use the StrInput class instead of the MessageInput class. The StrInput class is more appropriate for handling string inputs, and this change improves the clarity and consistency of the code.