Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aws bedrock to AgentComponent #4515

Merged
merged 16 commits into from
Nov 12, 2024

Conversation

edwinjosechittilappilly
Copy link
Collaborator

This pull request enhances the integration with Amazon Bedrock by adding support for new AWS models and regions, and updating the relevant components to use these new constants. The most important changes include the addition of new AWS model IDs and regions, and the modification of components to utilize these constants.

Enhancements to AWS Model and Region Support:

Integration with Amazon Bedrock Components:

update model list as constants
Add default value to Secret string variables
load_from_db false for session_token
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Nov 12, 2024
@edwinjosechittilappilly edwinjosechittilappilly changed the base branch from main to fix-aws-bedrock-components-secrets November 12, 2024 00:22
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 12, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Nov 12, 2024
@edwinjosechittilappilly edwinjosechittilappilly changed the base branch from fix-aws-bedrock-components-secrets to main November 12, 2024 00:23
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 12, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Nov 12, 2024
Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #4515 will degrade performances by 13.97%

Comparing feat-add-aws-bedrock-simple-agents (9909c1b) with main (4f90552)

Summary

❌ 1 regressions
✅ 14 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main feat-add-aws-bedrock-simple-agents Change
test_invalid_run_with_input_type_chat 13.9 ms 16.2 ms -13.97%

@ogabrielluiz ogabrielluiz changed the title feat: add aws bedrock simple agents feat: add aws bedrock to AgentComponent Nov 12, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Nov 12, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 12, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
@edwinjosechittilappilly edwinjosechittilappilly merged commit 145d67f into main Nov 12, 2024
29 checks passed
@edwinjosechittilappilly edwinjosechittilappilly deleted the feat-add-aws-bedrock-simple-agents branch November 12, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants