Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bedrock component handling AWS constants #4514

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

edwinjosechittilappilly
Copy link
Collaborator

This pull request introduces several changes to improve the handling of AWS constants and simplify the configuration of AWS-related components in the backend. The main updates include the addition of AWS model IDs and regions, and the refactoring of AWS-related inputs to use these constants.

AWS Constants Addition:

  • Added a list of AWS model IDs and AWS regions in the aws_constants.py file.

AWS Embeddings Component:

  • Imported AWS_REGIONS from aws_constants.py in amazon_bedrock.py.
  • Updated the AmazonBedrockEmbeddingsComponent class to use AWS_REGIONS for the region_name dropdown options.
  • Added default values for AWS credentials inputs in the AmazonBedrockEmbeddingsComponent class. [1] [2]

AWS Models Component:

  • Imported AWS_REGIONS and AWS_MODEL_IDs from aws_constants.py in amazon_bedrock.py.
  • Updated the AmazonBedrockComponent class to use AWS_MODEL_IDs for the model_id dropdown options.
  • Updated the AmazonBedrockComponent class to use AWS_REGIONS for the region_name dropdown options.
  • Added default values for AWS credentials inputs in the AmazonBedrockComponent class. [1] [2]

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 12, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 12, 2024
Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #4514 will not alter performance

Comparing fix-aws-bedrock-components-secrets (787b596) with main (f34d57a)

Summary

✅ 15 untouched benchmarks

Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
update model list as constants
Add default value to Secret string variables
load_from_db false for session_token
@ogabrielluiz ogabrielluiz force-pushed the fix-aws-bedrock-components-secrets branch from dc5b81e to c53a116 Compare November 12, 2024 12:10
@edwinjosechittilappilly edwinjosechittilappilly merged commit 516ba89 into main Nov 12, 2024
28 checks passed
@edwinjosechittilappilly edwinjosechittilappilly deleted the fix-aws-bedrock-components-secrets branch November 12, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants