Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Properly pass missing vectorize params in Astra DB #4511

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

erichare
Copy link
Collaborator

This pull request cleans up some of the authentication parameters, properly passing a None value with the authentication is empty to allow for connecting to a vector store generated with NVIDIA vectorize

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 11, 2024
Copy link

codspeed-hq bot commented Nov 11, 2024

CodSpeed Performance Report

Merging #4511 will degrade performances by 10.08%

Comparing bugfix-vectorize-params (e560007) with main (aea9804)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main bugfix-vectorize-params Change
test_invalid_run_with_input_type_chat 18 ms 14 ms +28.89%
test_successful_run_with_output_type_debug 410.2 ms 456.2 ms -10.08%

Copy link
Collaborator

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 11, 2024
@erichare erichare enabled auto-merge (squash) November 11, 2024 22:20
@erichare erichare merged commit a107650 into main Nov 11, 2024
36 of 37 checks passed
@erichare erichare deleted the bugfix-vectorize-params branch November 11, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants