Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change input display name of Webhook component to "Payload" #4507

Merged
merged 5 commits into from
Nov 11, 2024
Merged

fix: change input display name of Webhook component to "Payload" #4507

merged 5 commits into from
Nov 11, 2024

Conversation

Cristhianzl
Copy link
Collaborator

This pull request includes several changes to the src/backend/tests directory and a minor update to a component in the src/backend/base/langflow/components/data/webhook.py file. The changes primarily involve the addition and reorganization of imports across multiple test files.

Component Update:

@Cristhianzl Cristhianzl self-assigned this Nov 11, 2024
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 11, 2024
@Cristhianzl Cristhianzl changed the title fix: change input display name of webhook component to payload fix: change input display name of Webhook component to "Payload" Nov 11, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Nov 11, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 11, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 11, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 11, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4507 will degrade performances by 16.55%

Comparing cz/renaming-webhook-input (2082b0b) with main (29e4844)

Summary

❌ 2 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main cz/renaming-webhook-input Change
❌ test_invalid_run_with_input_type_chat 13.9 ms 16.7 ms -16.55%
❌ test_successful_run_with_input_type_text 450.9 ms 504.4 ms -10.59%

@Cristhianzl Cristhianzl enabled auto-merge (squash) November 11, 2024 20:48
@Cristhianzl Cristhianzl merged commit 133a8ae into main Nov 11, 2024
30 checks passed
@Cristhianzl Cristhianzl deleted the cz/renaming-webhook-input branch November 11, 2024 20:51
edwinjosechittilappilly pushed a commit that referenced this pull request Nov 11, 2024
@Cristhianzl @autofix-ci @edwinjosechittilappilly
fix: change input display name of Webhook component to "Payload" (#4507)
7b42b4d 
* change input display name of webhook component to payload

* [autofix.ci] apply automated fixes

* 📝 (docs): update formatting and alignment of tables in components-data.md to improve readability and consistency across the document

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

@italojohnny italojohnny Awaiting requested review from italojohnny

Assignees

@Cristhianzl Cristhianzl

Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cristhianzl @ogabrielluiz