Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update AWS Bedrock components descriptions #4503

Merged
merged 5 commits into from
Nov 11, 2024

Conversation

edwinjosechittilappilly
Copy link
Collaborator

This pull request includes significant updates to the AmazonBedrockEmbeddingsComponent and AmazonBedrockComponent classes to enhance AWS credential handling and configuration options. The changes primarily focus on improving the flexibility and security of AWS credentials management, as well as providing more detailed configuration options for AWS regions and endpoints.

Enhancements to AWS credentials handling and configuration:

  • Updated the AmazonBedrockEmbeddingsComponent class to replace aws_access_key and aws_secret_key with aws_access_key_id, aws_secret_access_key, and aws_session_token. Added detailed information for each input to guide users on setting environment variables.
  • Added a region_name dropdown input with a comprehensive list of AWS regions and an endpoint_url input to specify the AWS Bedrock endpoint in the AmazonBedrockEmbeddingsComponent class.
  • Improved the build_embeddings method in the AmazonBedrockEmbeddingsComponent class to use the new credential inputs and handle session tokens.
  • Updated the AmazonBedrockComponent class to include similar changes for AWS credentials and added a model_kwargs input for additional model configuration.
  • Enhanced the build_model method in the AmazonBedrockComponent class to use the new credential inputs and added error handling for boto3 session creation.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Nov 11, 2024
@github-actions github-actions bot added bug Something isn't working and removed enhancement New feature or request labels Nov 11, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 11, 2024
Copy link

codspeed-hq bot commented Nov 11, 2024

CodSpeed Performance Report

Merging #4503 will degrade performances by 90.75%

Comparing fix-bedrock-components (9caee68) with main (133a8ae)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix-bedrock-components Change
test_invalid_run_with_input_type_chat 16.8 ms 15.1 ms +11.43%
test_successful_run_with_output_type_any 454.4 ms 399.6 ms +13.71%
test_successful_run_with_output_type_debug 455.9 ms 4,926.4 ms -90.75%

@edwinjosechittilappilly edwinjosechittilappilly merged commit aea9804 into main Nov 11, 2024
30 checks passed
@edwinjosechittilappilly edwinjosechittilappilly deleted the fix-bedrock-components branch November 11, 2024 21:55
@ogabrielluiz ogabrielluiz changed the title fix: AWS Bedrock components refactor: update AWS Bedrock components descriptions Nov 11, 2024
@ogabrielluiz ogabrielluiz added refactor Maintenance tasks and housekeeping and removed bug Something isn't working labels Nov 11, 2024
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Nov 11, 2024
edwinjosechittilappilly added a commit that referenced this pull request Nov 11, 2024
* AWS Bedrock components update

* update in imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants