-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update AWS Bedrock components descriptions #4503
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwinjosechittilappilly
requested review from
italojohnny,
rodrigosnader,
ogabrielluiz and
carlosrcoelho
November 11, 2024 19:39
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
enhancement
New feature or request
labels
Nov 11, 2024
github-actions
bot
added
bug
Something isn't working
and removed
enhancement
New feature or request
labels
Nov 11, 2024
ogabrielluiz
requested changes
Nov 11, 2024
src/backend/base/langflow/components/embeddings/amazon_bedrock.py
Outdated
Show resolved
Hide resolved
ogabrielluiz
approved these changes
Nov 11, 2024
CodSpeed Performance ReportMerging #4503 will degrade performances by 90.75%Comparing Summary
Benchmarks breakdown
|
ogabrielluiz
changed the title
fix: AWS Bedrock components
refactor: update AWS Bedrock components descriptions
Nov 11, 2024
ogabrielluiz
added
refactor
Maintenance tasks and housekeeping
and removed
bug
Something isn't working
labels
Nov 11, 2024
github-actions
bot
added
refactor
Maintenance tasks and housekeeping
and removed
refactor
Maintenance tasks and housekeeping
labels
Nov 11, 2024
edwinjosechittilappilly
added a commit
that referenced
this pull request
Nov 11, 2024
* AWS Bedrock components update * update in imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to the
AmazonBedrockEmbeddingsComponent
andAmazonBedrockComponent
classes to enhance AWS credential handling and configuration options. The changes primarily focus on improving the flexibility and security of AWS credentials management, as well as providing more detailed configuration options for AWS regions and endpoints.Enhancements to AWS credentials handling and configuration:
AmazonBedrockEmbeddingsComponent
class to replaceaws_access_key
andaws_secret_key
withaws_access_key_id
,aws_secret_access_key
, andaws_session_token
. Added detailed information for each input to guide users on setting environment variables.region_name
dropdown input with a comprehensive list of AWS regions and anendpoint_url
input to specify the AWS Bedrock endpoint in theAmazonBedrockEmbeddingsComponent
class.build_embeddings
method in theAmazonBedrockEmbeddingsComponent
class to use the new credential inputs and handle session tokens.AmazonBedrockComponent
class to include similar changes for AWS credentials and added amodel_kwargs
input for additional model configuration.build_model
method in theAmazonBedrockComponent
class to use the new credential inputs and added error handling for boto3 session creation.