Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Simplify exception handling and refactor error messaging #4496

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This pull request simplifies the exception handling in the LCAgentComponent by removing redundant exception parameters and ensuring that nested exceptions are properly handled during message schema initialization. The ExceptionWithMessageError class has been refactored to streamline its usage, enhancing clarity and maintainability of the error handling logic.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 11, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 11, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 11, 2024
Copy link

codspeed-hq bot commented Nov 11, 2024

CodSpeed Performance Report

Merging #4496 will degrade performances by 23.91%

Comparing fix-agent-lock (1a783af) with main (5a6c556)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix-agent-lock Change
test_successful_run_with_input_type_any 504.4 ms 343.4 ms +46.88%
test_successful_run_with_input_type_text 404.2 ms 531.2 ms -23.91%

@ogabrielluiz ogabrielluiz merged commit 1188812 into main Nov 11, 2024
29 checks passed
@ogabrielluiz ogabrielluiz deleted the fix-agent-lock branch November 11, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants