Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding info to Agent and related components #4495

Merged
merged 8 commits into from
Nov 12, 2024

Conversation

edwinjosechittilappilly
Copy link
Collaborator

This pull request includes several updates to the agent.py and tool_calling.py files to add informative descriptions to various input fields. These changes aim to improve the clarity of the agent components by providing additional context for each input.

Enhancements to input field descriptions:

@github-actions github-actions bot added the bug Something isn't working label Nov 11, 2024
Copy link

codspeed-hq bot commented Nov 11, 2024

CodSpeed Performance Report

Merging #4495 will degrade performances by 24.95%

Comparing fix-agent-descriptions (61bd280) with main (768e6f0)

Summary

⚡ 3 improvements
❌ 2 regressions
✅ 10 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix-agent-descriptions Change
test_invalid_run_with_input_type_chat 22 ms 16.3 ms +34.76%
test_successful_run_with_input_type_any 455.9 ms 533.2 ms -14.49%
test_successful_run_with_input_type_text 581.9 ms 457.1 ms +27.31%
test_successful_run_with_output_type_any 456.6 ms 413.4 ms +10.46%
test_successful_run_with_output_type_debug 327.9 ms 436.9 ms -24.95%

Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @edwinjosechittilappilly

I think the info we want are directed towards newer Users so try to be almost ELI5 level

src/backend/base/langflow/components/agents/agent.py Outdated Show resolved Hide resolved
@edwinjosechittilappilly edwinjosechittilappilly marked this pull request as ready for review November 11, 2024 17:02
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Nov 11, 2024
@edwinjosechittilappilly edwinjosechittilappilly enabled auto-merge (squash) November 11, 2024 17:30
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
@ogabrielluiz ogabrielluiz force-pushed the fix-agent-descriptions branch from 52abcaf to 61bd280 Compare November 12, 2024 02:54
@edwinjosechittilappilly edwinjosechittilappilly merged commit bbaec2b into main Nov 12, 2024
28 checks passed
@edwinjosechittilappilly edwinjosechittilappilly deleted the fix-agent-descriptions branch November 12, 2024 03:03
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
* info added

* Update openai.py

update to Open AI model info

* info changed

* Update tool_calling.py

made info of LLM much simpler

* info updated to be simpler

* Update agent.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants