Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Small improvements to sidebar, customParams, and flowToolbar for easier DSLF merges #4487

Merged
merged 5 commits into from
Nov 11, 2024

Conversation

mfortman11
Copy link
Collaborator

Feature flag updates in FlowToolbar:

  • Hides Shared button when ENABLE_LANGFLOW_STORE flag is disabled. (src/frontend/src/components/flowToolbarComponent/index.tsx) [1] [2]

Popover component improvements:

  • Introduced PopoverAnchor to the popover component exports for better modularity. (src/frontend/src/components/ui/popover.tsx) [1] [2]

UI adjustment in Sidebar:

  • Modified the z-index of the sidebar for better layering control. Allows for header dropdowns to cover the sidebar (src/frontend/src/components/ui/sidebar.tsx)

Re add nodeId prop to CustomParameterComponent:

  • Updated getCustomParameterTitle to include nodeId so node details can be used for custom params. (src/frontend/src/customization/components/custom-parameter.tsx)

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. javascript Pull requests that update Javascript code labels Nov 11, 2024
@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Nov 11, 2024
Copy link
Collaborator

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 11, 2024
Copy link
Collaborator

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfortman11

can we improve the title of this PR to be more specific and explain better what It does?
thanks!

@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Nov 11, 2024
@mfortman11 mfortman11 changed the title refactor: DSLF refactor for easier merges refactor: Small improvements to sidebar, customParams, and flowToolbar for easier DSLF merges Nov 11, 2024
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Nov 11, 2024
@mfortman11 mfortman11 enabled auto-merge (squash) November 11, 2024 15:08
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 11, 2024
@mfortman11 mfortman11 merged commit f66f31d into langflow-ai:main Nov 11, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants