Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use AsyncSession in some non-blocking APIs #4484

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Nov 9, 2024

Fix sync/async DB usage in APIs:

  • flows
  • files
  • folders
  • monitor

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 9, 2024
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 9, 2024
@cbornet cbornet force-pushed the async-db-apis branch 3 times, most recently from c32827f to cb141ba Compare November 9, 2024 12:02
Copy link

codspeed-hq bot commented Nov 9, 2024

CodSpeed Performance Report

Merging #4484 will degrade performances by 16.28%

Comparing cbornet:async-db-apis (a730d2d) with main (19963de)

Summary

⚡ 2 improvements
❌ 2 regressions
✅ 11 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main cbornet:async-db-apis Change
test_invalid_run_with_input_type_chat 18.3 ms 14 ms +30.92%
test_successful_run_with_input_type_any 457.5 ms 546.5 ms -16.28%
test_successful_run_with_output_type_any 455.5 ms 532.3 ms -14.42%
test_successful_run_with_output_type_debug 509.8 ms 455 ms +12.04%

@cbornet cbornet force-pushed the async-db-apis branch 2 times, most recently from e6b2c95 to bf29652 Compare November 9, 2024 14:08
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 11, 2024
@cbornet cbornet force-pushed the async-db-apis branch 2 times, most recently from f721cd4 to 463cd0b Compare November 11, 2024 18:37
@cbornet cbornet enabled auto-merge (squash) November 11, 2024 18:39
@cbornet cbornet enabled auto-merge (squash) November 11, 2024 18:40
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Nov 11, 2024
@cbornet cbornet merged commit 8bb0f65 into langflow-ai:main Nov 11, 2024
28 checks passed
@cbornet cbornet deleted the async-db-apis branch November 12, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants