Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed component colors name to not override existing colors, fixed responsiveness issues on main, playground and nav #4482

Merged
merged 13 commits into from
Nov 8, 2024

Conversation

lucaseduoli
Copy link
Collaborator

This pull request includes several changes to improve the styling and functionality of various components in the frontend. The most important changes involve the removal of redundant CSS variables, updates to class names for consistency, and the replacement of color variables to better reflect their purpose.

Styling Improvements:

  • Removed redundant CSS variables and simplified the selected color styling in src/frontend/src/App.css.
  • Updated class names and color variables in NodeDescription and NodeOutputField components to improve readability and maintain consistency. [1] [2] [3]

Functional Enhancements:

  • Replaced accent color variables with datatype color variables in the HandleRenderComponent to better reflect their purpose and improve code clarity. [1] [2] [3]
  • Removed unused functions and simplified the structure in the HandleRenderComponent to enhance maintainability. [1] [2] [3] [4]

Additional Updates:

  • Modified navigation logic and adjusted layout in the MenuBar component to improve user experience. [1] [2] [3] [4] [5]
  • Added a Separator component to the IOModal for better visual separation of elements. [1] [2] [3] [4]
  • Updated color variables in various components to ensure consistent theming across the application. [1] [2] [3] [4]

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. javascript Pull requests that update Javascript code labels Nov 8, 2024
@lucaseduoli lucaseduoli self-assigned this Nov 8, 2024
Copy link
Collaborator

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 8, 2024
@lucaseduoli lucaseduoli enabled auto-merge (squash) November 8, 2024 21:02
@lucaseduoli lucaseduoli merged commit f32360f into main Nov 8, 2024
26 of 27 checks passed
@lucaseduoli lucaseduoli deleted the fix/quick_color_components branch November 8, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants