Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhance tool mapping and output rendering with animations #4481

Merged
merged 15 commits into from
Nov 11, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This pull request improves the tool block mapping by utilizing unique tool keys that combine the tool name and run ID. Additionally, it enhances the rendering of tool outputs in the ContentDisplay component by supporting both Markdown and JSON formatting. Animations have also been added for block titles and content separators in the ContentBlockDisplay component, providing a smoother user experience.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Nov 8, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Nov 8, 2024
Copy link

codspeed-hq bot commented Nov 8, 2024

CodSpeed Performance Report

Merging #4481 will improve performances by 17.12%

Comparing small-fixes-playground (fcf5c78) with main (1188812)

Summary

⚡ 2 improvements
✅ 13 untouched benchmarks

Benchmarks breakdown

Benchmark main small-fixes-playground Change
test_invalid_run_with_input_type_chat 16.5 ms 14.1 ms +17.12%
test_successful_run_with_input_type_any 531 ms 457.3 ms +16.14%

Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 11, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) November 11, 2024 16:29
@anovazzi1 anovazzi1 enabled auto-merge (squash) November 11, 2024 16:30
@anovazzi1 anovazzi1 merged commit 06b7450 into main Nov 11, 2024
31 checks passed
@anovazzi1 anovazzi1 deleted the small-fixes-playground branch November 11, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants