Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enable sorting of chat inputs to improve UI message speed #4480

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This pull request modifies the graph processing logic to prioritize chat inputs during sorting. By sorting chat inputs first, the speed at which user messages are sent to the UI is improved, enhancing overall user experience.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 8, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 8, 2024
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tested locally and seems faster to me

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 10, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) November 11, 2024 01:41
Copy link

codspeed-hq bot commented Nov 11, 2024

CodSpeed Performance Report

Merging #4480 will degrade performances by 24.06%

Comparing speedup-chat-input (31ae95d) with main (f43fd89)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main speedup-chat-input Change
test_invalid_run_with_input_type_chat 14.5 ms 19 ms -24.06%
test_successful_run_with_input_type_text 572.8 ms 371.5 ms +54.16%
test_successful_run_with_output_type_debug 452.5 ms 353.2 ms +28.14%

@ogabrielluiz ogabrielluiz merged commit 76c91de into main Nov 11, 2024
29 checks passed
@ogabrielluiz ogabrielluiz deleted the speedup-chat-input branch November 11, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants