Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove 'refresh_button' from DropdownInput in AgentComponent configuration #4471

Merged
merged 3 commits into from
Nov 8, 2024
Merged

fix: Remove 'refresh_button' from DropdownInput in AgentComponent configuration #4471

merged 3 commits into from
Nov 8, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This PR removes the 'refresh_button' option from the DropdownInput in the AgentComponent configuration, streamlining the component's interface and functionality.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 8, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 8, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 8, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4471 will degrade performances by 13.34%

Comparing fix-remove-agent-button (30122ad) with main (a4863bb)

Summary

⚡ 4 improvements
❌ 1 regressions
✅ 10 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix-remove-agent-button Change
⚡ test_build_flow 5,519.8 ms 690 ms ×8
⚡ test_invalid_run_with_input_type_chat 20.6 ms 17.6 ms +17.26%
⚡ test_successful_run_with_input_type_any 449.6 ms 397.5 ms +13.13%
❌ test_successful_run_with_input_type_text 419.6 ms 484.1 ms -13.34%
⚡ test_successful_run_with_output_type_any 528.3 ms 449.5 ms +17.54%

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 8, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 8, 2024
edwinjosechittilappilly
edwinjosechittilappilly approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@edwinjosechittilappilly edwinjosechittilappilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 8, 2024
@italojohnny italojohnny enabled auto-merge (squash) November 8, 2024 17:27
@italojohnny italojohnny merged commit c5495c4 into main Nov 8, 2024
28 checks passed
@italojohnny italojohnny deleted the fix-remove-agent-button branch November 8, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwinjosechittilappilly edwinjosechittilappilly edwinjosechittilappilly approved these changes

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ogabrielluiz @edwinjosechittilappilly @italojohnny