Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add temporary database setup for performance tests #4469

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This pull request introduces a temporary database setup for performance tests by creating a fixture that sets a test database URL. The fixture ensures that the original database URL is restored after the tests are completed. Additionally, assertions have been added to various performance tests to verify that the temporary database URL is being used during the tests. This change enhances the reliability of performance testing by isolating the test environment.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 8, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 8, 2024
@italojohnny italojohnny enabled auto-merge (squash) November 8, 2024 13:51
Copy link

codspeed-hq bot commented Nov 8, 2024

CodSpeed Performance Report

Merging #4469 will degrade performances by 28.27%

Comparing improve-benchmarks (7842a2f) with main (ed69253)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 12 untouched benchmarks

⁉️ 1 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main improve-benchmarks Change
test_load_flows 945.5 µs 1,318.1 µs -28.27%
test_setup_llm_caching 1.1 ms 1.6 ms -27.36%
test_successful_run_with_input_type_any 528.3 ms 471.5 ms +12.06%
⁉️ test_successful_run_with_input_type_chat 451.4 ms N/A N/A

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 8, 2024
@italojohnny italojohnny merged commit 7114cc4 into main Nov 8, 2024
29 checks passed
@italojohnny italojohnny deleted the improve-benchmarks branch November 8, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants